From f5e5f20e15e7e5f33a48c669d588aa3aaf07d5cd Mon Sep 17 00:00:00 2001 From: Dezinger Date: Sat, 18 Nov 2017 23:02:27 +0300 Subject: [PATCH 01/17] Security fix: add AccessControl to RuleController --- src/User/Controller/RuleController.php | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/src/User/Controller/RuleController.php b/src/User/Controller/RuleController.php index dbce6c2..ccd6134 100644 --- a/src/User/Controller/RuleController.php +++ b/src/User/Controller/RuleController.php @@ -17,10 +17,12 @@ use Da\User\Service\AuthRuleEditionService; use Da\User\Traits\AuthManagerAwareTrait; use Da\User\Traits\ContainerAwareTrait; use Da\User\Validator\AjaxRequestModelValidator; +use Da\User\Filter\AccessRuleFilter; use Yii; use yii\filters\VerbFilter; use yii\web\Controller; use yii\web\NotFoundHttpException; +use yii\filters\AccessControl; class RuleController extends Controller { @@ -33,12 +35,24 @@ class RuleController extends Controller public function behaviors() { return [ - [ + 'verbs' => [ 'class' => VerbFilter::className(), 'actions' => [ 'delete' => ['POST'], ], - ] + ], + 'access' => [ + 'class' => AccessControl::className(), + 'ruleConfig' => [ + 'class' => AccessRuleFilter::className(), + ], + 'rules' => [ + [ + 'allow' => true, + 'roles' => ['admin'], + ], + ], + ], ]; } From 6e80f0a62d3b2cf9c65fe38c66589683ba99f206 Mon Sep 17 00:00:00 2001 From: Dezinger Date: Sat, 18 Nov 2017 23:42:42 +0300 Subject: [PATCH 02/17] #115 Convert client_id to string because pgsql fail with type convertion string <> int --- src/User/Query/SocialNetworkAccountQuery.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/User/Query/SocialNetworkAccountQuery.php b/src/User/Query/SocialNetworkAccountQuery.php index 8ca2843..eee6d34 100644 --- a/src/User/Query/SocialNetworkAccountQuery.php +++ b/src/User/Query/SocialNetworkAccountQuery.php @@ -26,7 +26,7 @@ class SocialNetworkAccountQuery extends ActiveQuery return $this->andWhere( [ 'provider' => $client->getId(), - 'client_id' => $client->getUserAttributes()['id'], + 'client_id' => (string)$client->getUserAttributes()['id'], ] ); } From 94e44ad944fa3aa416c5283e364a30d3afb0027a Mon Sep 17 00:00:00 2001 From: Dezinger Date: Sun, 19 Nov 2017 00:15:47 +0300 Subject: [PATCH 03/17] 2FA i18n russian translation --- src/User/resources/i18n/ru/usuario.php | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/src/User/resources/i18n/ru/usuario.php b/src/User/resources/i18n/ru/usuario.php index 5fa7e97..35a2535 100644 --- a/src/User/resources/i18n/ru/usuario.php +++ b/src/User/resources/i18n/ru/usuario.php @@ -17,16 +17,16 @@ * NOTE: this file must be saved in UTF-8 encoding. */ return [ - 'Disable two factor authentication' => '', - 'Enable two factor authentication' => '', - 'Invalid two factor authentication code' => '', - 'This will disable two factor authentication. Are you sure?' => '', - 'Two Factor Authentication (2FA)' => '', - 'Two factor authentication code' => '', - 'Two factor authentication has been disabled.' => '', - 'Two factor authentication protects you against stolen credentials' => '', - 'Two factor authentication successfully enabled.' => '', - 'Unable to disable Two factor authentication.' => '', + 'Disable two factor authentication' => 'Выключить двухфакторную авторизацию', + 'Enable two factor authentication' => 'Включить двухфакторную авторизацию', + 'Invalid two factor authentication code' => 'Неверный код двухфакторной авторизации', + 'This will disable two factor authentication. Are you sure?' => 'Двухфакторная авторизация будет отключена. Вы уверены?', + 'Two Factor Authentication (2FA)' => 'Двухфакторная авторизация (2FA)', + 'Two factor authentication code' => 'Код двухфакторной авторизации', + 'Two factor authentication has been disabled.' => 'Двухфакторная авторизация отключена.', + 'Two factor authentication protects you against stolen credentials' => 'Двухфакторная авторизация защитит вас от кражи параметров доступа', + 'Two factor authentication successfully enabled.' => 'Двухфакторная авторизация успешно включена.', + 'Unable to disable Two factor authentication.' => 'Не удалось отключить двухфакторную авторизацию.', 'A message has been sent to your email address. ' => '@@Сообщение было отправлено на вашу электронную почту@@', 'Awesome, almost there. ' => '@@Замечательно, почти готово!@@', 'Class "{0}" does not exist' => '@@Класс "{0}" не найден@@', From 3718ae5332f4c24dbb95c291f0769c59883f2ce4 Mon Sep 17 00:00:00 2001 From: Dezinger Date: Wed, 22 Nov 2017 21:16:50 +0300 Subject: [PATCH 04/17] #119 Add to changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 4fbd66c..0145366 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,7 @@ # CHANGELOG ## 1.1.1 - Work in progress +- Bug #119: Security fix: add AccessControl to RuleController (Dezinger) - Bug #111: Fix migration for PostgreSQL DBMS (MKiselev) - Bug #106: Correct exception value returned in `MailEvent::getException` (kartik-v) - Enh #99: Added German translation (jkmssoft) From b2161c32240e4871418e37fcfd66384cf71f9f55 Mon Sep 17 00:00:00 2001 From: Dezinger Date: Wed, 22 Nov 2017 21:23:43 +0300 Subject: [PATCH 05/17] #115 Add to changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 4fbd66c..f2eeab8 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,7 @@ # CHANGELOG ## 1.1.1 - Work in progress +- Bug #115: Convert client_id to string because pgsql fail with type convertion (Dezinger) - Bug #111: Fix migration for PostgreSQL DBMS (MKiselev) - Bug #106: Correct exception value returned in `MailEvent::getException` (kartik-v) - Enh #99: Added German translation (jkmssoft) From 9c9be53f676ee60a9cdb99f51b6133113828401d Mon Sep 17 00:00:00 2001 From: Dezinger Date: Wed, 22 Nov 2017 21:28:31 +0300 Subject: [PATCH 06/17] #120 Add to changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 4fbd66c..17efc66 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,7 @@ # CHANGELOG ## 1.1.1 - Work in progress +- Enh #120: 2FA i18n russian translation (Dezinger) - Bug #111: Fix migration for PostgreSQL DBMS (MKiselev) - Bug #106: Correct exception value returned in `MailEvent::getException` (kartik-v) - Enh #99: Added German translation (jkmssoft) From 7cc7db608654dd9a55968bc0acdd53a6945bfbe4 Mon Sep 17 00:00:00 2001 From: Lorenzo Milesi Date: Mon, 27 Nov 2017 07:39:10 +0100 Subject: [PATCH 07/17] Updated 'it' --- src/User/resources/i18n/it/usuario.php | 92 +++++++++++--------------- 1 file changed, 38 insertions(+), 54 deletions(-) diff --git a/src/User/resources/i18n/it/usuario.php b/src/User/resources/i18n/it/usuario.php index 5206c44..6fd7758 100644 --- a/src/User/resources/i18n/it/usuario.php +++ b/src/User/resources/i18n/it/usuario.php @@ -17,59 +17,43 @@ * NOTE: this file must be saved in UTF-8 encoding. */ return [ - 'A message has been sent to your email address. It contains a confirmation link that you must click to complete registration.' => '', - 'Are you sure you wish to send a password recovery email to this user?' => '', - 'Awesome, almost there. Now you need to click the confirmation link sent to your new email address.' => '', - 'Awesome, almost there. Now you need to click the confirmation link sent to your old email address.' => '', - 'Cancel' => '', - 'Cannot assign role "{0}" as the AuthManager is not configured on your console application.' => '', - 'Close' => '', - 'Disable two factor authentication' => '', - 'Enable' => '', - 'Enable two factor authentication' => '', - 'Error sending registration message to "{email}". Please try again later.' => '', - 'Error sending welcome message to "{email}". Please try again later.' => '', - 'Invalid two factor authentication code' => '', - 'Last login' => '', - 'Never' => '', - 'Required "key" cannot be empty.' => '', - 'Required "secret" cannot be empty.' => '', - 'Role "{0}" not found. Creating it.' => '', - 'Scan the QrCode with Google Authenticator App, then insert its temporary code on the box and submit.' => '', - 'Send password recovery email' => '', - 'The "recaptcha" component must be configured.' => '', - 'The verification code is incorrect.' => '', - 'This will disable two factor authentication. Are you sure?' => '', - 'Two Factor Authentication (2FA)' => '', - 'Two factor authentication code' => '', - 'Two factor authentication has been disabled.' => '', - 'Two factor authentication protects you against stolen credentials' => '', - 'Two factor authentication successfully enabled.' => '', - 'Unable to disable Two factor authentication.' => '', - 'Unable to send recovery message to the user' => '', - 'User account could not be created.' => '', - 'User could not be registered.' => '', - 'User not found.' => '', - 'Verification failed. Please, enter new code.' => '', - 'We couldn\'t re-send the mail to confirm your address. Please, verify is the correct email or if it has been confirmed already.' => '', - 'We have sent confirmation links to both old and new email addresses. You must click both links to complete your request.' => '', - '{0} cannot be blank.' => '', - 'A message has been sent to your email address. ' => '@@È stato inviato un messaggio al tuo indirizzo email@@', - 'Awesome, almost there. ' => '@@Fantastico, ci siamo quasi. @@', - 'Disable Two-Factor Auth' => '@@@@', - 'Enable Two-factor auth' => '@@@@', - 'Invalid two-factor code' => '@@@@', - 'This will disable two-factor auth. Are you sure?' => '@@@@', - 'Two Factor Authentication' => '@@@@', - 'Two factor successfully enabled.' => '@@@@', - 'Two-Factor Authentication' => '@@@@', - 'Two-factor auth protects you against stolen credentials' => '@@@@', - 'Two-factor authentication code' => '@@@@', - 'Two-factor authorization has been disabled.' => '@@@@', - 'Two-factor code' => '@@@@', - 'Unable to disable two-factor authorization.' => '@@@@', - 'We couldn\'t re-send the mail to confirm your address. ' => '@@Non è stato possibile reinviare l\'email per confermare il tuo indirizzo. @@', - 'We have sent confirmation links to both old and new email addresses. ' => '@@Abbiamo inviato un link di conferma sia al nuovo che al vecchio indirizzo email. @@', + 'A message has been sent to your email address. It contains a confirmation link that you must click to complete registration.' => 'È stato inviato un messaggio al tuo indirizzo email. Contiene un collegamento di verifica che devi aprire per completare la registrazione.', + 'Are you sure you wish to send a password recovery email to this user?' => 'Sicuro di voler inviare un email di recupero password a questo utente?', + 'Awesome, almost there. Now you need to click the confirmation link sent to your new email address.' => 'Fantastico, ci siamo quasi. Ora devi solo visitare il collegamento di conferma che è stato inviato al tuo nuovo indirizzo email.', + 'Awesome, almost there. Now you need to click the confirmation link sent to your old email address.' => 'Fantastico, ci siamo quasi. Ora devi solo visitare il collegamento di conferma che è stato inviato al tuo vecchio indirizzo email.', + 'Cancel' => 'Annulla', + 'Cannot assign role "{0}" as the AuthManager is not configured on your console application.' => 'Impossibile assegnare il ruolo "{0}" perché l\'AuthManager non è configurato nella applicazione da console.', + 'Close' => 'Chiudi', + 'Disable two factor authentication' => 'Disabilita autenticazione a due fattori', + 'Enable' => 'Abilita', + 'Enable two factor authentication' => 'Abilita l\'autenticazione a due fattori', + 'Error sending registration message to "{email}". Please try again later.' => 'C\'è stato un errore nell\'invio del messaggio di registrazione all\'indirizzo "{email}". Per favore ritenta più tardi.', + 'Error sending welcome message to "{email}". Please try again later.' => 'C\'è stato un errore nell\'invio del messaggio di benvenuto all\'indirizzo "{email}". Per favore ritenta più tardi.', + 'Invalid two factor authentication code' => 'Il codice dell\'autenticazione a due fattori non è valido', + 'Last login' => 'Ultimo accesso', + 'Never' => 'Mai', + 'Required "key" cannot be empty.' => 'Il campo "chiave" è richiesto, non può essere vuoto.', + 'Required "secret" cannot be empty.' => 'Il campo "segreto" è richiesto, non può essere vuoto.', + 'Role "{0}" not found. Creating it.' => 'Ruolo "{0}" non trovato. È stato creato.', + 'Scan the QrCode with Google Authenticator App, then insert its temporary code on the box and submit.' => 'Scansiona il codice QR con l\'applicazione Google Authenticator, poi inserisci il codice temporaneo nel riquadro ed invia.', + 'Send password recovery email' => 'Invia email di recupero password', + 'The "recaptcha" component must be configured.' => 'Occorre configurare il componente "recaptcha".', + 'The verification code is incorrect.' => 'Il codice di verifica non è corretto.', + 'This will disable two factor authentication. Are you sure?' => 'Stai per disabilitare l\'autenticazione a due fattori. Sei sicuro?', + 'Two Factor Authentication (2FA)' => 'Autenticazione a due fattori (2FA)', + 'Two factor authentication code' => 'Codice di autenticazione a due fattori', + 'Two factor authentication has been disabled.' => 'Autenticazione a due fattori disabilitata.', + 'Two factor authentication protects you against stolen credentials' => 'L\'autenticazione a due fattori può proteggerti dal furto di credenziali', + 'Two factor authentication successfully enabled.' => 'Autenticazione a due fattori abilitata con successo.', + 'Unable to disable Two factor authentication.' => 'Impossibile disabilitare l\'autenticazione a due fattori.', + 'Unable to send recovery message to the user' => 'Impossibile inviare il messaggio di recupero password all\'utente', + 'User account could not be created.' => 'Impossibile creare il nuovo utente.', + 'User could not be registered.' => 'Impossibile registrare l\'utente.', + 'User not found.' => 'Utente non trovato.', + 'Verification failed. Please, enter new code.' => 'Verifica fallita. Per favore inserisci un nuovo codice.', + 'We couldn\'t re-send the mail to confirm your address. Please, verify is the correct email or if it has been confirmed already.' => 'Non siamo riusciti ad inviare una email di conferma al tuo indirizzo. Per favore verifica che sia corretto e che non sia già stato confermato.', + 'We have sent confirmation links to both old and new email addresses. You must click both links to complete your request.' => 'Abbiamo inviato un link di conferma sia al vecchio che al nuovo indirizzo email. Devi visitare entrambi i link per completare la richiesta.', + '{0} cannot be blank.' => '{0} non può essere vuoto.', '(not set)' => '(non impostato)', 'A confirmation message has been sent to your new email address' => 'È stato inviato un messaggio di conferma al tuo nuovo indirizzo email', 'A new confirmation link has been sent' => 'È stato inviato un nuovo link di conferma', @@ -208,7 +192,7 @@ return [ 'There is neither role nor permission with name "{0}"' => 'Non esiste un ruolo o permesso di nome "{0}', 'This account has already been connected to another user' => 'Questo account è già stato associato ad un altro utente', 'This email address has already been taken' => 'Questo indirizzo email è già stato registrato', - 'This username has already been taken' => 'Questo nome utente è già stato registraot', + 'This username has already been taken' => 'Questo nome utente è già stato registrato', 'Time zone' => 'Fuso orario', 'Time zone is not valid' => 'Il fuso orario non è valido', 'Unable to confirm user. Please, try again.' => 'Impossibile confermare l\'utente, per favore ritenta.', From 18acee75853e92138a8f45f0852ddea1b16996b5 Mon Sep 17 00:00:00 2001 From: Antonio Ramirez Date: Mon, 27 Nov 2017 16:10:07 +0100 Subject: [PATCH 08/17] re #111 update CHANGELOG --- CHANGELOG.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index e23b38e..6e0fa46 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,8 @@ # CHANGELOG -## 1.1.1 - Work in progress +## 1.1.2 - Work in progress + +## 1.1.1 - November 27, 2017 - Bug #115: Convert client_id to string because pgsql fail with type convertion (Dezinger) - Bug #119: Security fix: add AccessControl to RuleController (Dezinger) - Enh #120: 2FA i18n russian translation (Dezinger) From 9a923aaacef9d7932ebc843195d6a904fabf726d Mon Sep 17 00:00:00 2001 From: Liviu Calin Date: Fri, 1 Dec 2017 15:27:21 +0100 Subject: [PATCH 09/17] Fix wrong email on email change confirmation message, #122 --- src/User/Factory/MailFactory.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/User/Factory/MailFactory.php b/src/User/Factory/MailFactory.php index 0ba80df..13fd3e5 100644 --- a/src/User/Factory/MailFactory.php +++ b/src/User/Factory/MailFactory.php @@ -111,7 +111,7 @@ class MailFactory 'token' => $token, ]; - return static::makeMailerService(MailEvent::TYPE_RECONFIRM, $from, $to, $subject, 'recovery', $params); + return static::makeMailerService(MailEvent::TYPE_RECONFIRM, $from, $to, $subject, 'reconfirmation', $params); } /** From f0915a284a5dc8a538235b601609b08e2a66b1a3 Mon Sep 17 00:00:00 2001 From: Antonio Ramirez Date: Fri, 1 Dec 2017 16:52:00 +0100 Subject: [PATCH 10/17] Update CHANGELOG.md --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6e0fa46..d0dc6d7 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,7 @@ # CHANGELOG ## 1.1.2 - Work in progress +- Bug #122: Fix wrong email message for email address change (liviuk2) ## 1.1.1 - November 27, 2017 - Bug #115: Convert client_id to string because pgsql fail with type convertion (Dezinger) From 483a3253ff4239a7b515eaaf0dce460d51a84071 Mon Sep 17 00:00:00 2001 From: "E.Alamo" Date: Fri, 8 Dec 2017 18:00:48 +0100 Subject: [PATCH 11/17] Mispelling Also formal and informal ways were mixed in the same phrase. --- src/User/resources/i18n/es/usuario.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/User/resources/i18n/es/usuario.php b/src/User/resources/i18n/es/usuario.php index dd8fc68..3aebcb9 100644 --- a/src/User/resources/i18n/es/usuario.php +++ b/src/User/resources/i18n/es/usuario.php @@ -120,9 +120,9 @@ return [ 'Forgot password?' => '¿Olvidaste la contraseña?', 'Gravatar email' => 'Correo electrónico Gravatar', 'Hello' => 'Hola', - 'If you already registered, sign in and connect this account on settings page' => 'Si ya está registrados, inicie sesión y conecta esta cuenta en la página de configuración', - 'If you cannot click the link, please try pasting the text into your browser' => 'Si tienes problemas, por favor, pegua la siguiente dirección URL en su navegador web', - 'If you did not make this request you can ignore this email' => 'PD: Si ha recibido este correo electrónico por error, simplemente elimínelo', + 'If you already registered, sign in and connect this account on settings page' => 'Si ya estas registrado, inicia sesión y conecta esta cuenta en la página de configuración', + 'If you cannot click the link, please try pasting the text into your browser' => 'Si tienes problemas, por favor, pega la siguiente dirección URL en tu navegador web', + 'If you did not make this request you can ignore this email' => 'PD: Si has recibido este correo electrónico por error, simplemente elimínalo', 'Impersonate this user' => 'Personificar este usuario', 'In order to complete your registration, please click the link below' => 'Para completar el registro, por favor haz clic en el siguiente enlance', 'In order to complete your request, please click the link below' => 'Para completar tu petición, haz clic en el siguiente enlace', From 067862cee7ff9e6279190c4e7499e7c200ba0b4e Mon Sep 17 00:00:00 2001 From: Faenir Date: Mon, 11 Dec 2017 13:14:36 +0300 Subject: [PATCH 12/17] Fix validation (#125). --- src/User/Controller/AdminController.php | 2 +- src/User/Controller/RecoveryController.php | 2 +- src/User/Controller/RegistrationController.php | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/User/Controller/AdminController.php b/src/User/Controller/AdminController.php index 63ded04..7875629 100644 --- a/src/User/Controller/AdminController.php +++ b/src/User/Controller/AdminController.php @@ -130,7 +130,7 @@ class AdminController extends Controller $this->make(AjaxRequestModelValidator::class, [$user])->validate(); - if ($user->load(Yii::$app->request->post())) { + if ($user->load(Yii::$app->request->post()) && $user->validate()) { $this->trigger(UserEvent::EVENT_BEFORE_CREATE, $event); $mailService = MailFactory::makeWelcomeMailerService($user); diff --git a/src/User/Controller/RecoveryController.php b/src/User/Controller/RecoveryController.php index dee824b..cd2f621 100644 --- a/src/User/Controller/RecoveryController.php +++ b/src/User/Controller/RecoveryController.php @@ -94,7 +94,7 @@ class RecoveryController extends Controller $this->make(AjaxRequestModelValidator::class, [$form])->validate(); - if ($form->load(Yii::$app->request->post())) { + if ($form->load(Yii::$app->request->post()) && $form->validate()) { $this->trigger(FormEvent::EVENT_BEFORE_REQUEST, $event); $mailService = MailFactory::makeRecoveryMailerService($form->email); diff --git a/src/User/Controller/RegistrationController.php b/src/User/Controller/RegistrationController.php index f668387..2834f9d 100644 --- a/src/User/Controller/RegistrationController.php +++ b/src/User/Controller/RegistrationController.php @@ -145,7 +145,7 @@ class RegistrationController extends Controller $this->make(AjaxRequestModelValidator::class, [$user])->validate(); - if ($user->load(Yii::$app->request->post())) { + if ($user->load(Yii::$app->request->post()) && $user->validate()) { $this->trigger(SocialNetworkConnectEvent::EVENT_BEFORE_CONNECT, $event); $mailService = MailFactory::makeWelcomeMailerService($user); From 2e3673ff07a7a84d4f307b91ed569e5f27611f0a Mon Sep 17 00:00:00 2001 From: Faenir Date: Mon, 11 Dec 2017 13:15:26 +0300 Subject: [PATCH 13/17] Check is user found or not. --- src/User/Service/PasswordRecoveryService.php | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/User/Service/PasswordRecoveryService.php b/src/User/Service/PasswordRecoveryService.php index 265d9ce..5f319b0 100644 --- a/src/User/Service/PasswordRecoveryService.php +++ b/src/User/Service/PasswordRecoveryService.php @@ -42,6 +42,10 @@ class PasswordRecoveryService implements ServiceInterface /** @var User $user */ $user = $this->query->whereEmail($this->email)->one(); + if ($user === null) { + throw new \RuntimeException('User not found.'); + } + $token = TokenFactory::makeRecoveryToken($user->id); if (!$token) { From 4dc6c2f4cd2e45163949b0ffcb2b7488ee37fa73 Mon Sep 17 00:00:00 2001 From: Arthur Khachaturov Date: Tue, 12 Dec 2017 13:24:30 +0300 Subject: [PATCH 14/17] Update changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index d0dc6d7..41856fb 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,7 @@ # CHANGELOG ## 1.1.2 - Work in progress +- Bug #125: Fix validation in non-ajax requests (faenir) - Bug #122: Fix wrong email message for email address change (liviuk2) ## 1.1.1 - November 27, 2017 From 927ba821c65868c95cfaced126ff58808401b4bc Mon Sep 17 00:00:00 2001 From: Szymon Kargol Date: Tue, 19 Dec 2017 16:16:32 +0100 Subject: [PATCH 15/17] social-network-authentication.md typo fix --- docs/helpful-guides/social-network-authentication.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/helpful-guides/social-network-authentication.md b/docs/helpful-guides/social-network-authentication.md index 8c50641..8a9552a 100644 --- a/docs/helpful-guides/social-network-authentication.md +++ b/docs/helpful-guides/social-network-authentication.md @@ -31,7 +31,7 @@ After you need to configure the `authClientCollection::clients` on your Applicat 'facebook' => [ 'class' => 'Da\User\AuthClient\Facebook', 'clientId' => 'facebook_client_id', - 'clientScret' => 'facebook_client_secret' + 'clientSecret' => 'facebook_client_secret' ] ] ] From 4244f1cdb3ab11b31a1afc9ce8cb61706517a190 Mon Sep 17 00:00:00 2001 From: Francesco Fiore Date: Wed, 17 Jan 2018 15:51:17 +0100 Subject: [PATCH 16/17] Fix user search returning no results in admin page --- src/User/Search/UserSearch.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/User/Search/UserSearch.php b/src/User/Search/UserSearch.php index 17653e3..ea31688 100644 --- a/src/User/Search/UserSearch.php +++ b/src/User/Search/UserSearch.php @@ -63,7 +63,7 @@ class UserSearch extends Model { return [ 'safeFields' => [['username', 'email', 'registration_ip', 'created_at', 'last_login_at'], 'safe'], - 'createdDefault' => ['created_at', 'default', 'value' => null], + 'createdDefault' => [['created_at', 'last_login_at'], 'default', 'value' => null], ]; } From 1729a1f97a55fa83fa9f1ffd5e1950306580ed5a Mon Sep 17 00:00:00 2001 From: Francesco Fiore Date: Mon, 22 Jan 2018 10:36:08 +0100 Subject: [PATCH 17/17] Update CHANGELOG.md --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 41856fb..818a1ff 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,7 @@ # CHANGELOG ## 1.1.2 - Work in progress +- Bug #133: Fix user search returning no results in admin page (phiurs) - Bug #125: Fix validation in non-ajax requests (faenir) - Bug #122: Fix wrong email message for email address change (liviuk2)