From 4b1536f9348cf0bdf0a549f4da4cc008d04c5396 Mon Sep 17 00:00:00 2001 From: Wenceslaus Dsilva Date: Sun, 24 Sep 2023 16:10:44 +0530 Subject: [PATCH] fix(TwoFactorAuthenticationEnforceFilter.php): use $user variable instead of accessing Yii::$app->user->identity multiple times for better readability and performance fix(MailService.php): remove unnecessary whitespace before $this->mailer to improve code formatting --- src/User/Filter/TwoFactorAuthenticationEnforceFilter.php | 2 +- src/User/Service/MailService.php | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/User/Filter/TwoFactorAuthenticationEnforceFilter.php b/src/User/Filter/TwoFactorAuthenticationEnforceFilter.php index 537e1c4..f0d0709 100644 --- a/src/User/Filter/TwoFactorAuthenticationEnforceFilter.php +++ b/src/User/Filter/TwoFactorAuthenticationEnforceFilter.php @@ -40,7 +40,7 @@ class TwoFactorAuthenticationEnforceFilter extends ActionFilter $permissions = $module->twoFactorAuthenticationForcedPermissions; $user = Yii::$app->user->identity; - $itemsByUser = array_keys($this->getAuthManager()->getItemsByUser(Yii::$app->user->identity->id)); + $itemsByUser = array_keys($this->getAuthManager()->getItemsByUser($user->id)); if (!empty(array_intersect($permissions, $itemsByUser)) && !$user->auth_tf_enabled) { Yii::$app->session->setFlash('warning', Yii::t('usuario', 'Your role requires 2FA, you won\'t be able to use the application until you enable it')); return Yii::$app->response->redirect(['/user/settings/account'])->send(); diff --git a/src/User/Service/MailService.php b/src/User/Service/MailService.php index 0e9ac49..4e99d44 100644 --- a/src/User/Service/MailService.php +++ b/src/User/Service/MailService.php @@ -83,8 +83,7 @@ class MailService implements ServiceInterface */ public function run() { - - $result = $this->mailer + $result = $this->mailer ->compose(['html' => $this->view, 'text' => "text/{$this->view}"], $this->params) ->setFrom($this->from) ->setTo($this->to)