leonardo/yii2-usuario
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

PR #458 - code improvement required by @maxxer

Browse Source
This commit is contained in:
Antonio Cordeddu
2022-08-09 16:56:54 +02:00
parent 97a2de2f48
commit 52f81d431e
5 changed files with 18 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/User/Service/TwoFactorEmailCodeGeneratorService.php
View File

@ -53,6 +53,7 @@ class TwoFactorEmailCodeGeneratorService implements ServiceInterface
// check the sending emailYii::t(
if(!$mailService->run()){
Yii::$app->session->addFlash('error', Yii::t('usuario','The email sending failed, please check your configuration.'));
return false;
}else{
// put key in session
Yii::$app->session->set("email_code_time", date('Y-m-d H:i:s'));

23
src/User/Service/TwoFactorSmsCodeGeneratorService.php
View File

@ -65,20 +65,19 @@ class TwoFactorSmsCodeGeneratorService implements ServiceInterface
$user = $this->user;
$mobilePhone=$user->getAuthTfMobilePhone();
if( !(null===$mobilePhone) && $mobilePhone!='' ){
// send sms
$success = $this->smsSender->send($mobilePhone, $code);
if($success){
// put key in session
Yii::$app->session->set("sms_code_time", date('Y-m-d H:i:s'));
Yii::$app->session->set("sms_code", $code);
}else{
Yii::$app->session->addFlash('error', Yii::t('usuario','The sms sending failed, please check your configuration.'));
return false;
}
} else{
if( null===$mobilePhone || $mobilePhone=='' ){
Yii::$app->session->addFlash('error', Yii::t('usuario','Mobile phone not found, please check your profile'));
return false;
}
// send sms
$success = $this->smsSender->send($mobilePhone, $code);
if($success){
// put key in session
Yii::$app->session->set("sms_code_time", date('Y-m-d H:i:s'));
Yii::$app->session->set("sms_code", $code);
}else{
Yii::$app->session->addFlash('error', Yii::t('usuario','The sms sending failed, please check your configuration.'));
return false;
}
return true;
}