From 7fb900dfe10e1f891d156e07f4c9482813d38dac Mon Sep 17 00:00:00 2001
From: Antonio Cordeddu <coranto@yetopen.com>
Date: Fri, 12 Aug 2022 16:30:06 +0200
Subject: [PATCH] #458 - fix on variables not initialized

---
 src/User/Validator/TwoFactorEmailValidator.php       | 2 +-
 src/User/Validator/TwoFactorTextMessageValidator.php | 1 +
 src/User/resources/views/settings/account.php        | 1 +
 src/User/resources/views/settings/two-factor-sms.php | 2 +-
 4 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/User/Validator/TwoFactorEmailValidator.php b/src/User/Validator/TwoFactorEmailValidator.php
index b7619fd..29e3c5a 100644
--- a/src/User/Validator/TwoFactorEmailValidator.php
+++ b/src/User/Validator/TwoFactorEmailValidator.php
@@ -32,7 +32,7 @@ class TwoFactorEmailValidator extends TwoFactorCodeValidator
      * TwoFactorCodeValidator constructor.
      *
      * @param User $user
-     * @param $code
+     * @param string $code
      * @param int $cycles
      */
     public function __construct(User $user, $code, $cycles = 0)
diff --git a/src/User/Validator/TwoFactorTextMessageValidator.php b/src/User/Validator/TwoFactorTextMessageValidator.php
index 42930f8..21deb34 100644
--- a/src/User/Validator/TwoFactorTextMessageValidator.php
+++ b/src/User/Validator/TwoFactorTextMessageValidator.php
@@ -26,6 +26,7 @@ class TwoFactorTextMessageValidator extends TwoFactorCodeValidator
     protected $user;
     protected $code;
     protected $cycles;
+    protected $type;
 
     /**
      * TwoFactorCodeValidator constructor.
diff --git a/src/User/resources/views/settings/account.php b/src/User/resources/views/settings/account.php
index 4acfef0..71acb07 100644
--- a/src/User/resources/views/settings/account.php
+++ b/src/User/resources/views/settings/account.php
@@ -106,6 +106,7 @@ $module = Yii::$app->getModule('user');
                     <?php if (!$model->getUser()->auth_tf_enabled):  
                         $validators = $module->twoFactorAuthenticationValidators;
                         $theFirstFound = false; 
+                        $checked = '';
                         foreach( $validators as $name => $validator ) {
                             if($validator[ "enabled" ]){
                                 // I want to check in the radio field the first validator I get
diff --git a/src/User/resources/views/settings/two-factor-sms.php b/src/User/resources/views/settings/two-factor-sms.php
index 17823aa..ce033c9 100644
--- a/src/User/resources/views/settings/two-factor-sms.php
+++ b/src/User/resources/views/settings/two-factor-sms.php
@@ -10,7 +10,7 @@
 
 /** @var string $id */
 /** @var string $uri */
-/** @var string $mobilePhoneRegistration */
+/** @var string $mobilePhone */
 ?>
 
 <div id="phonenumbersection">