Always create flash messages, allow enableFlashMessages only to dictate display

Fixed inconsistent handling of flash messages and the `enableFlashMessages` config setting (#391)
2021-02-02 17:14:14 +00:00
parent 12ce0e67f2
commit 8505327f21
2 changed files with 6 additions and 8 deletions
--- a/src/User/Service/UserCreateService.php
+++ b/src/User/Service/UserCreateService.php
@ -75,8 +75,8 @@ class UserCreateService implements ServiceInterface
                    'Error sending welcome message to "{email}". Please try again later.',
                    ['email' => $model->email]
                );
-                // from web display a flash message (if enabled)
-                if ($this->getModule()->enableFlashMessages === true && is_a(Yii::$app, yii\web\Application::class)) {
+                // from web generate a flash message
+                if (is_a(Yii::$app, yii\web\Application::class)) {
                    Yii::$app->session->setFlash(
                        'warning',
                        $error_msg