diff --git a/CHANGELOG.md b/CHANGELOG.md index 5716b64..63dfca1 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,8 +2,10 @@ ## dev +- Fix: Two Factor Authentication - Filter - Blocks even when two factor authentication is enabled - Fix: update Dutch (nl) translations (squio) - Enh: possibility to limit the depth of the recursion when getting user ids from roles (mp1509) +- Fix: UserSearch avoid fields name conflict if joined with other tables (liviuk2) ## 1.6.1 March 4th, 2023 diff --git a/src/User/Filter/TwoFactorAuthenticationEnforceFilter.php b/src/User/Filter/TwoFactorAuthenticationEnforceFilter.php index bcb09dc..f0d0709 100644 --- a/src/User/Filter/TwoFactorAuthenticationEnforceFilter.php +++ b/src/User/Filter/TwoFactorAuthenticationEnforceFilter.php @@ -38,8 +38,10 @@ class TwoFactorAuthenticationEnforceFilter extends ActionFilter } $permissions = $module->twoFactorAuthenticationForcedPermissions; - $itemsByUser = array_keys($this->getAuthManager()->getItemsByUser(Yii::$app->user->identity->id)); - if (!empty(array_intersect($permissions, $itemsByUser))) { + + $user = Yii::$app->user->identity; + $itemsByUser = array_keys($this->getAuthManager()->getItemsByUser($user->id)); + if (!empty(array_intersect($permissions, $itemsByUser)) && !$user->auth_tf_enabled) { Yii::$app->session->setFlash('warning', Yii::t('usuario', 'Your role requires 2FA, you won\'t be able to use the application until you enable it')); return Yii::$app->response->redirect(['/user/settings/account'])->send(); } diff --git a/src/User/Search/UserSearch.php b/src/User/Search/UserSearch.php index ae462d9..b936766 100644 --- a/src/User/Search/UserSearch.php +++ b/src/User/Search/UserSearch.php @@ -11,7 +11,9 @@ namespace Da\User\Search; +use Da\User\Model\User; use Da\User\Query\UserQuery; +use Da\User\Traits\ContainerAwareTrait; use Yii; use yii\base\InvalidParamException; use yii\base\Model; @@ -19,6 +21,8 @@ use yii\data\ActiveDataProvider; class UserSearch extends Model { + use ContainerAwareTrait; + /** * @var string */ @@ -106,21 +110,23 @@ class UserSearch extends Model return $dataProvider; } + $userClass = $this->getClassMap()->get(User::class); + if ($this->created_at !== null) { $date = strtotime($this->created_at); - $query->andFilterWhere(['between', 'created_at', $date, $date + 3600 * 24]); + $query->andFilterWhere(['between', $userClass::tableName().'.created_at', $date, $date + 3600 * 24]); } if ($this->last_login_at !== null) { $date = strtotime($this->last_login_at); - $query->andFilterWhere(['between', 'last_login_at', $date, $date + 3600 * 24]); + $query->andFilterWhere(['between', $userClass::tableName().'.last_login_at', $date, $date + 3600 * 24]); } $query - ->andFilterWhere(['like', 'username', $this->username]) - ->andFilterWhere(['like', 'email', $this->email]) - ->andFilterWhere(['registration_ip' => $this->registration_ip]) - ->andFilterWhere(['last_login_ip' => $this->last_login_ip]); + ->andFilterWhere(['like', $userClass::tableName().'.username', $this->username]) + ->andFilterWhere(['like', $userClass::tableName().'.email', $this->email]) + ->andFilterWhere([$userClass::tableName().'.registration_ip' => $this->registration_ip]) + ->andFilterWhere([$userClass::tableName().'.last_login_ip' => $this->last_login_ip]); return $dataProvider; } diff --git a/src/User/Service/MailService.php b/src/User/Service/MailService.php index 39b52ee..4e99d44 100644 --- a/src/User/Service/MailService.php +++ b/src/User/Service/MailService.php @@ -83,11 +83,16 @@ class MailService implements ServiceInterface */ public function run() { - return $this->mailer + $result = $this->mailer ->compose(['html' => $this->view, 'text' => "text/{$this->view}"], $this->params) ->setFrom($this->from) ->setTo($this->to) ->setSubject($this->subject) ->send(); + + if (!$result) { + Yii::error("Email sending failed to '{$this->to}'.", 'mailer'); + } + return $result; } } diff --git a/src/User/Validator/TwoFactorEmailValidator.php b/src/User/Validator/TwoFactorEmailValidator.php index 37bedce..9466a05 100644 --- a/src/User/Validator/TwoFactorEmailValidator.php +++ b/src/User/Validator/TwoFactorEmailValidator.php @@ -111,6 +111,6 @@ class TwoFactorEmailValidator extends TwoFactorCodeValidator */ public function generateCode() { - return $this->make(TwoFactorEmailCodeGeneratorService::class, $this->user)->run(); + return $this->make(TwoFactorEmailCodeGeneratorService::class, [$this->user])->run(); } }